Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bulk decompression for small limits #6666

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Feb 16, 2024

It is about 10x faster than row-by-row decompression, so if we're going to decompress 10x less rows than the batch size, it's more efficient to decompress row-by-row.

In tsbench, this improves lateral join queries (asof-style) by 30%: https://grafana.ops.savannah-dev.timescale.com/d/fasYic_4z/compare-akuzm?orgId=1&var-branch=All&var-run1=3284&var-run2=3287&var-threshold=0&var-use_historical_thresholds=true&var-threshold_expression=2.5%20%2A%20percentile_cont%280.90%29&var-exact_suite_version=false

Disable-check: force-changelog-file

It is about 10x faster than row-by-row decompression, so if we're going
to decompress 10x less rows than the batch size, it's more efficient to
decompress row-by-row.
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 81.46%. Comparing base (59f50f2) to head (47d9c74).
Report is 50 commits behind head on main.

❗ Current head 47d9c74 differs from pull request most recent head b08ce74. Consider uploading reports for the commit b08ce74 to get more accurate results

Files Patch % Lines
tsl/src/planner.c 81.03% 6 Missing and 5 partials ⚠️
tsl/src/nodes/decompress_chunk/planner.c 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6666      +/-   ##
==========================================
+ Coverage   80.06%   81.46%   +1.40%     
==========================================
  Files         190      190              
  Lines       37181    36452     -729     
  Branches     9450     9470      +20     
==========================================
- Hits        29770    29697      -73     
+ Misses       2997     2983      -14     
+ Partials     4414     3772     -642     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant