-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add role based auth to CloudWatch exporter doc #3156
Merged
Merged
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e2d9d4e
Add role based auth to CloudWatch exporter doc
minkimipt 86edfa1
add provider URLs and role example
niconosenzo 606acbc
Clarify what the URL serves for
niconosenzo 69db011
chore: first go updating the configuration procedure.
billy-the-fish faa7bc5
chore: updates after first review.
billy-the-fish 660442c
chore: updates after first review.
billy-the-fish cf2578a
Update use-timescale/metrics-logging/integrations.md
billy-the-fish 899f9db
fix: update metatags for MDX.
billy-the-fish db3b498
Replace trust policy to a role
minkimipt 4e94e7f
Update use-timescale/metrics-logging/integrations.md
billy-the-fish 61f9779
Merge branch 'latest' into update-cloudwatch-exporter-ingetrations
billy-the-fish db0bf9f
Merge branch 'latest' into update-cloudwatch-exporter-ingetrations
billy-the-fish File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niconosenzo why do we call it trust policy here if it's a role?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 it was the trust policy that began in line 152 of my commit. Will double check though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we want to be aligned with how AWS calls them in the blog, we need to call it a role with a trust policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, for me it's always easier to split a role among permission policies and trust policies. But yeah we can call it a role if that makes more sense.