x-timeplus http header #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenziliang
requested review from
qijun-niu-timeplus,
lizhou1111,
kuiliu88,
ye11ow and
zliang-min
and removed request for
kuiliu88
|
@ye11ow @zliang-min , fyi, please let us know if there are dependencies regarding the |
chenziliang
commented
May 13, 2024
| } | ||
|
|
||
| namespace | ||
| { | ||
| String base64Decode(const String & encoded) | ||
| String base64Decode(const String & encoded) |
There was a problem hiding this comment.
Reformatting ...
|
Unless the proton SDK relies on such headers, otherwise, Neutron and other components should not use any such headers. |
ye11ow
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
proton: starts/endsfor new code in existing community code base ?Please write user-readable short description of the changes: