Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak default sharding rule for one shard stream with primary keys #709

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

tweak default sharding rule for one shard stream with primary keys #709

wants to merge 1 commit into from

Conversation

yl-lisen
Copy link
Collaborator

PR checklist:

  • Did you run ClangFormat ?
  • Did you separate headers to a different section in existing community code base ?
  • Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:
This close #708

@yl-lisen yl-lisen self-assigned this May 13, 2024
yokofly
yokofly reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@yokofly yokofly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add a test for this change.
https://github.com/timeplus-io/proton/blob/develop/src/Interpreters/Streaming/tests/gtest_ddl_helper.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yokofly yokofly yokofly left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@yl-lisen yl-lisen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip sharding for versioned kv with one shard
2 participants
@yl-lisen @yokofly