Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinct_retract supports numeric processing #608

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Sake169
Copy link

@Sake169 Sake169 commented Mar 15, 2024

PR checklist:

  • Did you run ClangFormat ?
  • Did you separate headers to a different section in existing community code base ?
  • Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:
Current the distinct_retract function serialized no matter what the datatype is into string, it is very expensive, now it will just serialize the multiple key into string just like the distinct_streaming.
this should close #519

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2024

CLA assistant check
All committers have signed the CLA.

@jovezhong
Copy link
Contributor

Thank you for contributing this, @Sake169
Let me start the build process, in the meanwhile, we will look into the code

@jovezhong
Copy link
Contributor

The related ticket is #607

@Sake169 Sake169 force-pushed the enhancement/issue-519-improve-distinct_retract-aggregation-logic branch from 79a076b to 511df00 Compare March 18, 2024 02:03
@lizhou1111 lizhou1111 self-assigned this Mar 18, 2024
@lizhou1111 lizhou1111 removed their assignment Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve distinct_retract aggregation logic.
4 participants