Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Stream: Add Support for Apache Pulsar #556

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Kartik1397
Copy link

@Kartik1397 Kartik1397 commented Feb 5, 2024

PR checklist:

  • Did you run ClangFormat ?
    No (TODO)
  • Did you separate headers to a different section in existing community code base ?
    No (TODO)
  • Did you surround proton: starts/ends for new code in existing community code base ?
    No (TODO)

Please write user-readable short description of the changes:
TODO

Checklist:

  • Setup dev environment
  • Setup code auto completion
  • Working skeleton code
  • Evaluate KoP
  • Pulsar integration
    • Add Pulsar in deps
    • Pulsar client setup
    • Pulsar consumer setup
    • Pulsar topic validation
    • Read from pulsar & stream
    • Write to pulsar & stream
  • Add test cases

/claim #338

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Kartik1397
❌ Ubuntu


Ubuntu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jovezhong
Copy link
Contributor

Congratulations, @Kartik1397 , for submitting the first PR to Timeplus Proton.

I am assigning @zliang-min as the reviewers, since he is the main person behind Kafka External Stream and ClickHouse External Table. Once this is PR is ready to review, let us know.

@jovezhong
Copy link
Contributor

Hi @Kartik1397 , I'd like to check with you about the progress of the external stream for Apache Pulsar. Can you give us a rough percentage of readiness? Say 50%, more or less? We got some customer requirements to use such Pulsar integration in our core engine. So we need to prioritize it.

@Kartik1397
Copy link
Author

Kartik1397 commented Apr 23, 2024

Hi @jovezhong , In terms of progress I'm still at 40%. I can read from pulsar to proton but I'm facing issues while streaming result back to client. So, I was exploring TCPHandler & Serialisation part of proton since past few days. Attached exact error if anyone is interested. Write to pulsar is completely pending.

If someone else want to finish remaining parts, I'm okay with it. I've pushed all the code changes I've done till now in this PR.

Current blocker:

Code: 49. DB::Exception: Received from localhost:8463. DB::Exception: Bad cast from type DB::ColumnVector<char8_t> to DB::ColumnString. (LOGICAL_ERROR)

@jovezhong
Copy link
Contributor

Hi @Kartik1397 , thanks for sharing the progress and issue. @zliang-min will work on this feature and he can take a look at your current code and provide some support. Are you on our community slack https://timeplus.com/slack ? Maybe we can have a group chat/meeting there.

@Kartik1397
Copy link
Author

Sure @jovezhong, I'm on the slack. Kartik Prajapati is my username.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants