This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
Refactor ViewJson #106
Open
Refactor ViewJson #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move text property routing into routable ViewBehaviorRoutable - Move sparse fields handling into new ModelBehaviorSparsable - Only set the default model properties when a new row is created
The property might not be present in the data during insert or update. If the behavior is supported always set the property during insert and or update.
|
@ercanozkaya Can you have a look at this and see if I missed something here? |
| @@ -90,7 +90,7 @@ protected function _afterSelect(DatabaseContext $context) | |||
| { | |||
| if($this->getMixer() instanceof DatabaseRowInterface && $this->_auto_generate && !$this->isNew()) | |||
| { | |||
| if($this->hasProperty('uuid') && empty($this->uuid)) | |||
| if(empty($this->uuid)) | |||
There was a problem hiding this comment.
Won't this apply if the table has no uuid col?
There was a problem hiding this comment.
No the isSupported() method explicitly check if the table has a uuid column. No need to double check it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #105