Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Turn Nginx and VCL configs into reusable format strings #66

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

stevenrombauts
Copy link
Contributor

Closes #65

@stevenrombauts stevenrombauts added this to the 0.10.0 milestone Dec 13, 2017
@stevenrombauts stevenrombauts self-assigned this Dec 13, 2017
@stevenrombauts
Copy link
Contributor Author

@johanjanssens These changes turn your config files for Nginx and Varnish into a format we use with sprintf() in joomlatools/joomlatools-console. Could you check if this is OK with you, please?

Note:

  • The /varnish-enabled health probe URL is changed to simply / - otherwise it will never work on box right now.
  • Also removed the old Nooku Server specific exceptions (APC, phpmyadmin, ..)

@johanjanssens
Copy link
Member

@stevenrombauts How do you want me to test this?

@stevenrombauts
Copy link
Contributor Author

@johanjanssens Testing instructions are at joomlatools/joomlatools-console#79 (comment), the changes in this repo are very small but need your review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants