Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify header/footer usage #150

Closed
Levdbas opened this issue Feb 27, 2024 · 0 comments 路 Fixed by #156
Closed

Simplify header/footer usage #150

Levdbas opened this issue Feb 27, 2024 · 0 comments 路 Fixed by #156

Comments

@Levdbas
Copy link
Member

Levdbas commented Feb 27, 2024 

          > Gotcha, in my case, I never uses the footer.php solution in my 100+ timber projects :D So I think running those two hooks mimics that. I self-assigned this to add this to the docs.

馃憤

Btw, in starter we also have the header.php besides the footer.php. I never used that as well. Shall I create a PR implementing my suggested code and get rid of those two files?

Yes, I鈥檇 be all for that. From comments I have seen in various places, it鈥檚 not clear to everyone what these files do. So if we can have a simpler solution, let鈥檚 do that.

Originally posted by @gchtr in timber/timber#2420 (comment)
@Levdbas Levdbas changed the title > Gotcha, in my case, I never uses the footer.php solution in my 100+ timber projects :D So I think running those two hooks mimics that. I self-assigned this to add this to the docs. Simplify header/footer usage Feb 27, 2024
@Levdbas Levdbas linked a pull request May 2, 2024 that will close this issue
feat: update template basis #156
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update template basis timber/starter-theme
1 participant
@Levdbas