Release 4.23.0 - August 1st, 2021

.github/ISSUE_TEMPLATE/bug-report.md

@@ -4,93 +4,31 @@ about: "Use this template if the genuine builds of Nuvola aren't working as expe
 
 ---
 
-<!-- Thank you for taking the time to report a new issue.
+### Before creating a new bug report
 
-Before reporting a new issue:
+We recommend these actions first:
 
-1. Use genuine builds of Nuvola available from <https://nuvola.tiliado.eu>.
-    If you use a third-party build, contact your distributor to get help.
-    We don't have resources to support packages we know nothing about.
-2. Use the latest release of Nuvola. Update often, Flatpak updates are safe.
-    Run  "flatpak update --system; flatpak update --user" to make sure
-    all your Nuvola packages are up-to-date.
--->
+- [ ] Update Nuvola Player - run `flatpak update --system; flatpak update --user`
+- [ ] [Go through a list of recently updated issues](https://github.com/tiliado/nuvolaruntime/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc)
+- [ ] [Read bug reporting guidelines](https://github.com/tiliado/nuvolaplayer/wiki/Bug-Reporting-Guidelines)
 
-### Basic information
-
-- Your Linux distribution and its version: ...
-   <!--
-   Replace "..." with your answer, e.g. "Ubuntu 18.04". If you don't know,
-   you can use commands "lsb_release -d" or "cat /etc/issue /etc/*release"
-   to find out that.
-   -->
 
-- Your desktop environment: ...
-   <!--
-   Replace "..." with your desktop environment, e.g.
-   GNOME (default in Ubuntu 17.10 and newer, in Fedora),
-   Unity (default in Ubuntu 17.04 and older),
-   Patheon (default in elementaryOS),
-   Cinnamon (default in Linux Mint)
-   KDE, XFCE, MATE, ...
-   -->
+### Basic information
 
- - Nuvola Runtime version: ...
-   <!--
-   Replace "..." with the version of Nuvola Runtime.
-   You can get it from About dialog, click Menu button, then About.
-   -->
+We often need some basic information - refer to [bug reporting guidelines](https://github.com/tiliado/nuvolaplayer/wiki/Bug-Reporting-Guidelines)
+for help.
 
- - The web app you use and its version: ...
-   <!--
-   Replace "..." with the name (e.g. Deezer, Spotify) and version of
-   the web app you use.
-   You can get it from About dialog, click Menu button, then About.
-   -->
+- Nuvola Player version: ...
+- The streaming service you use and its version: ...
 
 ### Describe the bug
 
-<!-- Replace "..." with a clear and concise description of what the bug is. -->
-...
-
-**Steps to reproduce the behavior**
-
-<!-- Replace this list with your own steps. -->
-
-1. Go to '...'
-2. Click on '....'
-3. Scroll down to '....'
-4. See error
-
-**Expected behavior**
-
-<!-- Replace "..." with a clear and concise description of what you expected to happen. -->
-...
-
-**Debugging log**
-
-<!--
-See https://github.com/tiliado/nuvolaruntime/wiki/Bug-Reporting-Guidelines#debugging-output
-for instructions on how to get a debugging log. Then save it as a text file (*.txt) and attach it to the bug report.
-
-- Use the "Attach files by dragging & dropping or selecting them." feature available under the textbox.
-- Never trim the logs or you will be asked to provide new complete logs.
-- Don't use "pastebin" services as the logs there may disappear anytime.
-- Don't attach screenshots of the terminal output. Use text files.
--->
-Attach the debug log here: ...
-
-**Screenshots**
-
-<!--
-If applicable, add screenshots to help explain your problem.
-
-- Use the "Attach files by dragging & dropping or selecting them." feature available under the textbox.
-- Don't use image hosting services as the images may disappear anytime.
--->
-Attach screenshots here: ...
+Please describe the issue in great detail to help us understand what the problem is. You may include:
 
-**Additional context**
+- Exact steps to trigger the issue.
+- Wrong behavior.
+- Expected behavior.
+- Screenshots.
+- Any additional information that you think could help us help you.
 
-<!-- Add any other context about the problem. -->
-...
+Never share your e-mail, password or license key.

.github/ISSUE_TEMPLATE/feature-request.md

@@ -6,42 +6,21 @@ about: "Use this template if you have a suggestion (and may want get it implemen
 
 **Please describe in detail what you would like to solve with the proposed feature:**
 
-<!--
-Example 1: When I click a close button of the Nuvola window, music stops playing and Nuvola quits.
+Replace this example: When I click a close button of the Nuvola window, music stops playing and Nuvola quits.
 I'd prefer Nuvola to keep playing in the background instead.
--->
 
-<!--
-Example 2: I use Pomodoro technique to organize work time and I'm listening to Deep Focus playlist when I'm working.
-I'd like Nuvola to stop playing when a work period (25 minute) ends and resume playback
-when a new work period starts after a break (5 or 15 minutes).
-
-More details about Pomodoro: https://en.wikipedia.org/wiki/Pomodoro_Technique
--->
-
-Write your text here...
 
 **Do you have an idea how it could be solved and how it should look like?**
 
-<!--
-Example 1: Please add new settings "Run in background when the window is closed" with three options:
+Replace this example: Please add new settings "Run in background when the window is closed" with three options:
 "Always"/"When music is playing (default)"/"Never".
--->
 
-<!--
-Example 2: Please add a Pomodoro feature that stops/resumes music playback as described above.
-Add a button to the title bar of the main window to activate the functionality.
-Add a timer showing the remaining time next to the button.
-These options should be configurable: The length of the work interval, the length of the short break,
-the length of the long break, the number of work intervals before a long break.
--->
-
-Write your text here...
 
 **Describe alternatives you've considered:**
 
 Write your text here...
 
+
 **Additional context:**
 
 Add any other context or screenshots about the feature request here.

CHANGELOG.md

@@ -7,6 +7,24 @@ Nuvola Player Changelog
     [Nuvola Devel mailing list](https://groups.google.com/d/forum/nuvola-player-devel)
     to receive more technical announcements and important information about future development.
 
+Release 4.23.0 - August 1st, 2021
+---------------------------------
+
+This is a concise changelog. Refer to [Nuvola News](https://medium.com/nuvola-news) for a more verbose one and to see
+some screenshots.
+
+### What’s New for Users
+
+* SoundCloud script 1.7: Fix Google sign-in.
+
+* Spotify script 3.6:
+  Fix too narrow track list on artist page. [[GitHub ticket](https://github.com/tiliado/nuvolaplayer/issues/732)]
+  Fix playback actions. [[GitHub ticket](https://github.com/tiliado/nuvolaplayer/issues/739)]
+
+* YouTube Music script 1.6: Fix playback state parsing. [[GitHub ticket](https://github.com/tiliado/nuvolaplayer/issues/750)]
+
+* Deprecated scripts: Amazon Music and Tidal services are no longer compatible with Nuvola Player.
+
 Release 4.22.0 - May 9th, 2021
 ------------------------------
 
@@ -41,7 +59,7 @@ some screenshots.
 
 * New script: Anghami. Maintainer: Jiří Janoušek • [Source code](https://github.com/tiliado/nuvola-app-anghami)
 
-* Official support for Linux Mint, Cinnamon and Mate.e to test environment-specific integration issues.
+* Official support for Linux Mint, Cinnamon and Mate to test environment-specific integration issues.
 
 * Spotify script 3.4
   * Fix next and repeat actions. [[GitHub PR](https://github.com/tiliado/nuvola-app-spotify/pull/28)]

src/nuvolakit-runner/AppRunnerController.vala

@@ -406,7 +406,6 @@ public class AppRunnerController: Drtgtk.Application {
 
     private void load_app() {
         set_app_menu_items({
-            Actions.SURVEY,
             Actions.PREFERENCES, Actions.REPORT_BUG, Actions.ASK_QUESTION, Actions.REQUEST_FEATURE,
             Actions.HELP, Actions.NEWS, Actions.ABOUT, Actions.QUIT});
         main_window.set_menu_button_items({
@@ -433,7 +432,6 @@ public class AppRunnerController: Drtgtk.Application {
     private void append_actions() {
         unowned ActionsHelper ah = actions_helper;
         Drtgtk.Action[] actions_spec = {
-            ah.simple_action("main", "app", Actions.SURVEY, "Nuvola Survey 2021", null, null, null, do_open_survey),
             ah.simple_action("main", "app", Actions.PREFERENCES, "Preferences", "_Preferences", null, null, do_preferences),
             ah.toggle_action("main", "win", Actions.TOGGLE_SIDEBAR, "Show sidebar", "Show _sidebar", null, null, do_toggle_sidebar, false),
             ah.simple_action("go", "app", Actions.GO_HOME, "Home", "_Home", "go-home", "<alt>Home", web_engine.go_home),
@@ -567,26 +565,12 @@ public class AppRunnerController: Drtgtk.Application {
         preferences_dialog = null;
     }
 
-    private void do_open_survey() {
-        show_uri(survey.get_survey_url() ?? TiliadoSurvey.INFO_URL);
-    }
-
     private void update_survey() {
         TiliadoLicense? license = tiliado_paywall.get_gumroad_license();
         if (license == null || !license.is_valid()) {
             survey.survey_key = null;
         } else {
             survey.survey_key = license.license.license_key;
-
-            if (!config.get_bool("infobar.survey_2021_closed")) {
-                show_info_bar(
-                    "feature-voting",
-                    Gtk.MessageType.INFO,
-                    "<b>You may participate in Nuvola Player Survey 2021.</b>\nWe need your help "
-                    + "to obtain the valuable insight we can use to shape the future of the project.",
-                    {"Open survey"}
-                );
-            }
         }
     }
 
@@ -804,16 +788,6 @@ public class AppRunnerController: Drtgtk.Application {
                 break;
             }
             break;
-        case "feature-voting":
-            switch (response) {
-            case 0:
-                do_open_survey();
-                break;
-            case Gtk.ResponseType.CLOSE:
-                config.set_bool("infobar.survey_2021_closed", true);
-                break;
-            }
-            break;
         }
     }
 

src/nuvolakit-runner/core/Actions.vala

@@ -42,6 +42,5 @@ public const string ZOOM_IN = "zoom-in";
 public const string ZOOM_OUT = "zoom-out";
 public const string ZOOM_RESET = "zoom-reset";
 public const string QUIT = "quit";
-public const string SURVEY = "open-survey";
 
 } // namespace Nuvola.Actions

src/nuvolakit-runner/gui/PatronBox.vala

@@ -46,6 +46,7 @@ public class PatronBox : Gtk.Grid {
             "Andrew Allen", null,
             "Nathan Warkentin", "https://www.facebook.com/fur0n",
             "Chuck Talk", "https://www.linkedin.com/in/ctalk",
+            "Peter Tillemans", "https://www.snamellit.com",
         };
         var buffer = new StringBuilder("");
         int count = patrons.length / 2;

wscript

@@ -31,13 +31,13 @@ out = 'build'
 APPNAME = SHORT_ID = "nuvolaruntime"
 NUVOLA_BIN = "nuvola"
 NUVOLACTL_BIN = "nuvolactl"
-VERSION = "4.21.0"
+VERSION = "4.23.0"
 GENERIC_NAME = "Cloud Player"
 BLURB = "Tight integration of web-based media streaming services with your Linux desktop"
 DEFAULT_HELP_URL = "https://github.com/tiliado/nuvolaruntime/wiki/Third-Party-Builds"
 DEFAULT_WEB_APP_REQUIREMENTS_HELP_URL = DEFAULT_HELP_URL
 
-MIN_DIORITE = "4.22.0"
+MIN_DIORITE = "4.23.0"
 MIN_VALA = "0.48.0"
 MIN_GLIB = "2.56.1"
 MIN_GTK = "3.22.30"