On invalid geometry make valid and clean #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clean) for the on_invalid_geometry parameter
…clean) for the on_invalid_geometry parameter
pnorman
reviewed
Nov 15, 2016
mapbox_vector_tile/polygon.py
Outdated
| else: | ||
| for ls in boundary: | ||
| if lnum == 0: | ||
| exterior_lines.append(ls) | ||
| else: | ||
| interior_lines.append(ls) | ||
| interior_lines.append(ls) |
zerebubuth
approved these changes
Nov 15, 2016
|
Is there a reason why we always don't want to perform this operation? ie, right before returning a multipolygon in the other make valid path, always ensure it's "cleaned" first? |
rmarianski
requested changes
Dec 16, 2016
There was a problem hiding this comment.
Sorry, I commented separately but didn't officially "review". Can we update the make_it_valid function to fold in the multi polygon logic you added directly? Or is there a reason why it has to be separate?
Also looks like there's a merge conflict now, can you rebase off master?
|
@engobi Can you bring this PR up to date, please? |
rmarianski
reviewed
May 11, 2017
| @@ -913,6 +913,9 @@ def test_too_small_geometry(self): | |||
| on_invalid_geometry=on_invalid_geometry_make_valid) | |||
| result = decode(pbf) | |||
| features = result['foo']['features'] | |||
| import sys | |||
| sys.stderr.write(str(features)) | |||
| sys.stderr.write("\n") | |||
There was a problem hiding this comment.
Did you mean to have these prints in here?
rmarianski
approved these changes
May 11, 2017
|
this has been open for a while, any appetite to try and get this merged in still? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new geometry validity function on_invalid_geometry_make_valid_and_clean, that applies the validity function clean_multi in case of invalids multipolygons have been returned by make_it_valid function.