Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Images Version Sorting #341

Merged
merged 6 commits into from
May 5, 2024
Merged

Fix Images Version Sorting #341

merged 6 commits into from
May 5, 2024

Conversation

tonysm
Copy link
Contributor

@tonysm tonysm commented May 4, 2024 •
edited

Changed

  • Fixes the version sorting so we consider semver image tags higher than the other distro-specific or flavored image tag names

closes #337

Screenshots

typesense
sqs
solr
singlestore
redis
postgres
postgis
opensearch
neo4j
mysql
mssql
mongo
minio
memcached
meilisearch
mariadb
mailpit
maildev
influxdb
expose
eventstoredb
elasticsearch

gcavanunez
gcavanunez approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@gcavanunez gcavanunez left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! ran it locally, lists were sorting nicely, I feel like this really opens things up to turning this field into a combox/search select terminal prompt

tests/Feature/VersionComparatorTest.php
/**
* @test
*
* @testWith [["latest", "8.0"], ["latest", "8.0"]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

jakebathman
jakebathman approved these changes May 4, 2024
View reviewed changes
Copy link

@jakebathman jakebathman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, nice work getting it more simplified and using that new comparator class. I haven't run this locally but if Guillermo has then that's great.

@tonysm
Copy link
Contributor Author

tonysm commented May 5, 2024

I've also tested this on an M1 and it works. One thing I want to eventually handle is that it should consider 8.0 as higher than 8.0.45, but that can be enhanced later.

@tonysm tonysm merged commit c9ca14d into main May 5, 2024
11 checks passed
@tonysm tonysm deleted the tm/version-sorting branch May 5, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebathman jakebathman jakebathman approved these changes

@gcavanunez gcavanunez gcavanunez approved these changes

@mattstauffer mattstauffer Awaiting requested review from mattstauffer

@driftingly driftingly Awaiting requested review from driftingly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to install mongo
3 participants
@tonysm @jakebathman @gcavanunez