MySQL Tweaks #340
Merged
MySQL Tweaks #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd drop the default-authentication-plugin on MySQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
--default-authentication-pluginflag that we are setting saying it doesn't exist (from Fix MySQL default auth for PHP < 7.4 #116). I don't see that same flag being set on Laravel Sail. After testing without it, I was able to connect from my host machine, then created a sample Laravel Sail project to use the Takeout MySQL container, and it works. So we're dropping it.MYSQL_ALLOW_EMPTY_PASSWORDflag can always be set to1instead of making it dynamic based on the password used.