Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing PHPUnit BC break on base TestCase #701

Closed
wants to merge 7 commits into from

Conversation

njames
Copy link
Contributor

@njames njames commented Mar 18, 2024

I am updatating jigsaw's packages to get to a point where I can add laravel/prompts
PHPUnit 11 seems to have a BC break - anyone know about this?

TBC This PR is not ready yet I am just trying to get other eyes on the PHPUnit issue.

An error occurred inside PHPUnit.

Message:  Too few arguments to function PHPUnit\Framework\TestCase::__construct(), 0 passed in /Users/nigeljames/OS/jigsaw/tests/TestCase.php on line 31 and exactly 1 expected
Location: /Users/nigeljames/OS/jigsaw/vendor/phpunit/phpunit/src/Framework/TestCase.php:224

I have resolved this with https://stackoverflow.com/a/66676166 and I am now working on other updates with Symphony packages.

@njames
Copy link
Contributor Author

njames commented Mar 19, 2024

OK so now composer update and jigsaw init will run but the tests are failing still.

I have fixed the first couple of PHPUnit and Symfony errors I have come across and now have a markdown error.

I am keeping my commits granular and hopefully this helps.

CC @bakerkretzmar

@bakerkretzmar
Copy link
Collaborator

@njames thanks a lot for digging into this 🙏🏻

If I remember correctly, strictly speaking we can't upgrade the mnapoli markdown packages without a major version bump to Jigsaw itself, because there are backwards-incompatible changes to some public interfaces. I can take a closer look later but that looks like it's the issue with at least some of the failing tests here.

If we decide we don't mind bumping Jigsaw to v2 just to do those upgrades, then this PR looks like a great start and I'd be happy to jump in and help get things passing this week.

@damiani
Copy link
Contributor

damiani commented Mar 19, 2024

I've run through and made a handful of PHPUnit fixes, and I currently have all tests passing; the only markdown-related error was a missing return type. I'll take a closer look to the mnapoli changes that @bakerkretzmar mentioned, to see if there are indeed any breaking changes that would require a major version bump for Jigsaw.

@damiani
Copy link
Contributor

damiani commented Mar 26, 2024

Addressed in #702

@damiani damiani closed this Mar 26, 2024
@njames njames deleted the nj/add-prompts branch March 27, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants