Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pack() and unpack() generic #1372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make pack() and unpack() generic #1372

wants to merge 1 commit into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 10, 2022

Useful now that duckdb supports them with the DBI interface: duckdb/duckdb#3495.

@krlmlr krlmlr requested a review from DavisVaughan June 12, 2022 04:28
@krlmlr
Copy link
Member Author

krlmlr commented Jun 12, 2022

I wonder if we should instead define new generics build_pack_spec() and pack_spec(), similarly for "unpack". The DuckDB implementation is copying a bit of code from tidyr: duckdb/duckdb#3829.

@olivroy olivroy mentioned this pull request Apr 4, 2024
Open
@olivroy
Copy link
Contributor

olivroy commented Apr 4, 2024 •
edited

I may be mistaken, but I think this would help separate_wider_delim() / separate_wider_regex() work with sf objects. Is there a plan to merge this PR? (r-spatial/sf#2359)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavisVaughan DavisVaughan Awaiting requested review from DavisVaughan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krlmlr @olivroy