Skip to content

Commit

Permalink
Prepare for release
Browse files Browse the repository at this point in the history
  • Loading branch information
hadley committed Mar 28, 2016
1 parent 10a3a20 commit 794759f
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 40 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
@@ -1,6 +1,6 @@
Package: readxl
Title: Read Excel Files
Version: 0.1.0.9000
Version: 0.1.1
Authors@R: c(
person("Hadley", "Wickham", ,"hadley@rstudio.com", role = c("aut", "cre")),
person("RStudio", role = "cph", comment = "Copyright holder of all R code
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
@@ -1,4 +1,4 @@
# readxl 0.1.0.9000
# readxl 0.1.1

* Add support for correctly reading strings in .xlsx files containing escaped
unicode characters (e.g. `_x005F_`) (#51, thanks to @jmarshallnz).
47 changes: 9 additions & 38 deletions cran-comments.md
@@ -1,46 +1,17 @@
## Changes

This is a resubmission. In the third round of changes:

* I use C++11 where available - this ensures C99 support for included C code.

----

In the second round of changes:

* I clarified the copyright status of the package.

* Clarified in the description that the package only works on Linux, Mac and
Windows. Clearly the libxls package does not work on solaris. I have
the skill to make minor fixes, but getting it working on a big endian
system is beyond my abilities.

---

In the first round of changes:

* The DESCRIPTION now includes the individual readxl authors
* I have noted in LICENSE that libxls is licensed with BSD 2-clause
* I have wrapped external package names with single quotes
* I have eliminated many compiler warnings (all that I find across the
compilers I have in mac, windows, and ubuntu).
* The package now builds and checks on Solaris (with gcc)

Please note that the libxls webpage is severly out of date: it describes libxls 0.2.0, where the current (bundled) version is 1.4.0. I don't have an big-endian machine to test the code on, but the code includes endianness checks which leads me to suspect it is supported. Similarly, I have experimentally verified that libxls supports Excel 95 workbooks, despite the claim on the webpage.

## Test environments
* local OS X install, R 3.1.3
* ubuntu 12.04 (on travis-ci), R 3.1.3
* local OS X install, R 3.2.4
* ubuntu 12.04 (on travis-ci), R 3.2.4
* win-builder (devel and release)

## R CMD check results
There were no ERRORs or WARNINGs.

There were 2 NOTEs:
0 errors | 0 warnings | 1 note

* The LICENSE file specifies precisely the license of the included libxls
code.

* This is a new submission
The package still fails on solaris, due to endian-ness bugs in the wrapped libxls library.

* The BSD 2 clause license for libxls is now listed in LICENSE.
## Reverse dependencies

## Downstream dependencies
This is a new submission
I did not run R CMD check on the reverse dependencies because this release only fixes minor R CMD check notes, and a test failure illuminated by the dev version of testthat.

0 comments on commit 794759f

Please sign in to comment.