Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the dead appdirs dependency by platformdirs #811

Merged
merged 2 commits into from Apr 24, 2024

Conversation

mwerlen
Copy link
Contributor

@mwerlen mwerlen commented Mar 29, 2024

Hello,

python3-appdirs has been announced as dead upstream and its Debian maintainer has indicated that it should not be included in trixie (the next stable release). A recommended replacement is python3-platformdirs, which is a fork of appdirs with a very similar API.

I've prepared this MR to apply the recommanded easy replacement.
This change conserve the path of the cache and config dirs.

Maxime

Copy link
Contributor

@Jamstah Jamstah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: James Hewitt <james.hewitt@gmail.com>
Copy link
Owner

@thp thp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean patch, thanks!

@thp thp merged commit 342dd6a into thp:master Apr 24, 2024
5 checks passed
@e-dschungel
Copy link
Contributor

The doc still mentions the the outdated appdirs:

python3 -m pip install pyyaml minidb requests keyring appdirs lxml cssselect

@Jamstah Jamstah mentioned this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants