Add re.findall to pick out re matches #805
Conversation
|
Draft because it needs documentation. |
There was a problem hiding this comment.
In general, I don't mind a re.findall(), but people might be tempted to use it to "parse" HTML (which is not possible using regex) when the CSS or XPath filters are more suited for the job.
If we make it clear in the docs when it isn't and when it is the right tool for the job, I'm happy to merge this :)
|
Yeah, I was thinking that but was too lazy to think of a good example :) I've borrowed something from another test, and added some doc. |
Actually using re.finditer so we can apply a repl to the result. This allows users to pick out matches and reformat them in one step. Fixes thp#804 Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
| following example applies the filter 3 times: | ||
| You can use ``re.sub`` and ``re.findall`` to apply regular expressions. | ||
|
|
||
| ``re.sub`` can be used to remove of replace all non-overlapping instances |
There was a problem hiding this comment.
| ``re.sub`` can be used to remove of replace all non-overlapping instances | |
| ``re.sub`` can be used to remove or replace all non-overlapping instances |
| url: https://example.com/regex-findall.html | ||
| filter: | ||
| - re.findall: | ||
| pattern: 'The next draw is on (\d\d\d\d-\d\d-\d\d).' |
There was a problem hiding this comment.
Maybe:
| pattern: 'The next draw is on (\d\d\d\d-\d\d-\d\d).' | |
| pattern: 'The next draw is on (\d{4}-\d{2}-\d{2}).' |
| - re.findall: | ||
| pattern: 'The next draw is on (\d\d\d\d-\d\d-\d\d).' | ||
| repl: '\1' | ||
| - re.findall: '[0-9]+' |
There was a problem hiding this comment.
Maybe:
| - re.findall: '[0-9]+' | |
| - re.findall: '\d+' |
| XPATH expressions. HTML and XML cannot be parsed properly using regular | ||
| expressions. If the CSS selector or XPATH cannot provide the targeted |
There was a problem hiding this comment.
Could add a link to https://stackoverflow.com/a/1732454/1047040 on "cannot be parsed" for extra entertainment.
Actually using re.finditer so we can apply a repl to the result. This allows users to pick out matches and reformat them in one step.
Fixes #804