Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for sending to multiple recipients via sendmail #797

Merged
merged 7 commits into from Mar 12, 2024

Conversation

monperrus
Copy link
Contributor

if the to config contains multiple emails such as x@foo.com,y@bar.com

@Jamstah
Copy link
Contributor

Jamstah commented Feb 22, 2024

Does this also work for the smtp method? That field should probably work the same for both mechanisms.

This PR is missing documentation (although the doc doesn't mention sendmail at all), and an entry in the changelog.

@monperrus
Copy link
Contributor Author

Does this also work for the smtp method?

Yes, it already works for SMTP

This PR is missing documentation and an entry in the changelog.

Done.

Thanks!

docs/source/reporters.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@Jamstah Jamstah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a to in the example would make sense, but otherwise, it looks good to me.

FYI (in case you didn't know already), I'm not a maintainer, just helping out, so you'll need a maintainer to actually do the approve/merge.

Copy link
Owner

@thp thp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, two small comments.

CHANGELOG.md Outdated Show resolved Hide resolved
docs/source/reporters.rst Outdated Show resolved Hide resolved
monperrus and others added 2 commits March 12, 2024 07:28
Co-authored-by: Thomas Perl <m@thp.io>
Co-authored-by: Thomas Perl <m@thp.io>
@monperrus
Copy link
Contributor Author

Thanks for the review, applied the changes.

Copy link
Owner

@thp thp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thp thp merged commit 5c0b15c into thp:master Mar 12, 2024
5 checks passed
@monperrus
Copy link
Contributor Author

monperrus commented Mar 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants