Add encrypted cookie option #992
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with rubygems 3.4.6
… new option overrides signed_cookie settings. no tests so far
… new option overrides signed_cookie settings. no tests so far
…o add_encrypted_cookie_option # Conflicts: # lib/clearance/configuration.rb # lib/clearance/session.rb # spec/support/request_with_remember_token.rb
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -96,6 +96,12 @@ class Configuration | |||
| # @return [Boolean|:migrate] | |||
| attr_reader :signed_cookie | |||
|
|
|||
| # Controls whether cookies are encrypted. | |||
| # Defaults to `nil` for backwards compatibility. | |||
| # When not nil overrides signed_cookie settings and if true uses Rails' encrypted cookies | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [93/80]
| when true | ||
| cookies.signed[remember_token_cookie] | ||
| when :migrate | ||
| cookies.signed[remember_token_cookie] || cookies[remember_token_cookie] |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [81/80]
| when true | ||
| cookies.encrypted[remember_token_cookie] | ||
| when :migrate | ||
| cookies.encrypted[remember_token_cookie] || cookies[remember_token_cookie] |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [84/80]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My code may not be the most elaborate solution, but if it suits someone this could be a starting point.
There are no Unit-Test for it atm, but it works for me in a production app.