Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test deprecation warnings #1018

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix test deprecation warnings #1018

wants to merge 3 commits into from

Conversation

louis-antonopoulos
Copy link

This PR:

  • Addresses two different deprecation warnings that appear when running tests:
DEPRECATION WARNING: The `exist` matcher overrides one built-in by RSpec; 
use `expect(Pathname.new(path)).to exist` instead

DEPRECATION WARNING: Using legacy connection handling is deprecated. 
Please set `legacy_connection_handling` to `false` in your application.

@louis-antonopoulos
Copy link
Author

I believe CI is failing here due to the issues resolved by #1017.

@louis-antonopoulos
Use Pathname.new in install_generator_spec
42e0e7e 
Fix DEPRECATION WARNING: The `exist` matcher overrides one built-in by RSpec; use `expect(Pathname.new(path)).to exist` instead
@louis-antonopoulos
Disable config.active_record.legacy_connection_handling
99ae3c1 
Fix DEPRECATION WARNING: Using legacy connection handling is deprecated. Please set `legacy_connection_handling` to `false` in your application.
@louis-antonopoulos
Add #get_migration helper
319a081 
Using `Pathname.new` in tests results in a Hound error because of line length.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sej3506 sej3506 Awaiting requested review from sej3506 sej3506 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@louis-antonopoulos