Generate and render acknowledgements as Settings.bundle #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 17, 2019
sharplet
force-pushed
the
as-acknowledgements
branch
from
886d822
to
9ce5d23
Compare
danbee
reviewed
Mar 29, 2019
sharplet
force-pushed
the
as-acknowledgements
branch
from
9ce5d23
to
70ca910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores functionality that was previously provided by cocoapods-acknowledgements (CocoaPods was removed in #224).
The two main parts of this are the
generate-acknowledgementscommand line tool, written as a small Swift program, and a newAcknowledgementsViewController.