test: added more tests for AdministrationHelper class

thorsten · May 13, 2024 · 5bf10f8 · 5bf10f8
1 parent ed86570
commit 5bf10f8
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 3 deletions.
diff --git a/phpmyfaq/admin/faqs.editor.php b/phpmyfaq/admin/faqs.editor.php
@@ -41,7 +41,6 @@
 use phpMyFAQ\Template\UserNameTwigExtension;
 use phpMyFAQ\Translation;
 use phpMyFAQ\User\CurrentUser;
-use phpMyFAQ\Utils;
 use Twig\Extension\DebugExtension;
 
 if (!defined('IS_VALID_PHPMYFAQ')) {
@@ -136,11 +135,13 @@
                 ],
             ]
         );
+
         if (is_array($selectedCategory)) {
             foreach ($selectedCategory as $cats) {
                 $categories[] = ['category_id' => $cats, 'category_lang' => $faqData['lang']];
             }
         }
+
         $faqData['active'] = Filter::filterInput(INPUT_POST, 'active', FILTER_SANITIZE_SPECIAL_CHARS);
         $faqData['keywords'] = Filter::filterInput(INPUT_POST, 'keywords', FILTER_SANITIZE_SPECIAL_CHARS);
         $faqData['title'] = Filter::filterInput(INPUT_POST, 'thema', FILTER_SANITIZE_SPECIAL_CHARS);

diff --git a/phpmyfaq/src/phpMyFAQ/Helper/AdministrationHelper.php b/phpmyfaq/src/phpMyFAQ/Helper/AdministrationHelper.php
@@ -53,7 +53,7 @@ public function addMenuEntry(
         bool $checkPerm = true
     ): string {
 
-        if ($action != '') {
+        if ($action !== '') {
             $action = 'action=' . $action;
         }
 

diff --git a/tests/phpMyFAQ/Helper/AdministrationHelperTest.php b/tests/phpMyFAQ/Helper/AdministrationHelperTest.php
@@ -2,6 +2,9 @@
 
 namespace phpMyFAQ\Helper;
 
+use phpMyFAQ\Enums\ReleaseType;
+use phpMyFAQ\Strings;
+use phpMyFAQ\Translation;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -14,9 +17,27 @@ class AdministrationHelperTest extends TestCase
 
     protected function setUp(): void
     {
+        parent::setUp();
+
+        Strings::init();
+
+        Translation::create()
+            ->setLanguagesDir(PMF_TRANSLATION_DIR)
+            ->setDefaultLanguage('en')
+            ->setCurrentLanguage('en')
+            ->setMultiByteLanguage();
+
         $this->instance = new AdministrationHelper();
     }
 
+    public function testAddMenuEntry(): void
+    {
+        $expected = '<a class="nav-link" href="?action=edit">Categories</a>' . "\n";
+        $actual = $this->instance->addMenuEntry('', 'edit', 'ad_menu_categ_edit', '', false);
+
+        $this->assertEquals($expected, $actual);
+    }
+
     public function testRenderMetaRobotsDropdown(): void
     {
         $expected = '<option selected>index, follow</option><option>index, nofollow</option>' .
@@ -26,4 +47,25 @@ public function testRenderMetaRobotsDropdown(): void
         $this->assertEquals($expected, $actual);
     }
 
-} 
+    public function testRenderReleaseTypeOptions(): void
+    {
+        $optionsDevelopment = AdministrationHelper::renderReleaseTypeOptions(ReleaseType::DEVELOPMENT->value);
+        $optionsStable = AdministrationHelper::renderReleaseTypeOptions(ReleaseType::STABLE->value);
+        $optionsNightly = AdministrationHelper::renderReleaseTypeOptions(ReleaseType::NIGHTLY->value);
+
+        // Assert the HTML output for each release type
+        $expectedDevelopment = '<option value="development" selected>Development</option>' .
+            '<option value="stable">Stable</option>' .
+            '<option value="nightly">Nightly</option>';
+        $expectedStable = '<option value="development">Development</option>' .
+            '<option value="stable" selected>Stable</option>' .
+            '<option value="nightly">Nightly</option>';
+        $expectedNightly = '<option value="development">Development</option>' .
+            '<option value="stable">Stable</option>' .
+            '<option value="nightly" selected>Nightly</option>';
+
+        $this->assertEquals($expectedDevelopment, $optionsDevelopment);
+        $this->assertEquals($expectedStable, $optionsStable);
+        $this->assertEquals($expectedNightly, $optionsNightly);
+    }
+}