Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Pre-Shared-Key (PSK-TLS) connections #780

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for Pre-Shared-Key (PSK-TLS) connections #780

wants to merge 1 commit into from

Conversation

tringenbach
Copy link

  • Option added to Certificates dialog even though it's not really a cert
    • Seemed like the best / most "TLS advanced option" place After all, it's used INSTEAD of a cert
  • Uses the username as the identity
    • a future advancement might add a pskIdentity field, since technically it doesn't have to be the same
  • Requires unchecking Verify TLS
    • There's no cert to verify when using PSK

@tringenbach
Add support for Pre-Shared-Key (PSK-TLS) connections
d3dac7c 
- Option added to Certificates dialog even though it's not really a cert
  - Seemed like the best / most "TLS advanced option" place
    After all, it's used INSTEAD of a cert
- Uses the username as the identity
  - a future advancement might add a pskIdentity field, since technically
    it doesn't have to be the same
- Requires unchecking Verify TLS
  - There's no cert to verify when using PSK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasnordquist thomasnordquist thomasnordquist approved these changes

@bj00rn bj00rn bj00rn approved these changes

Assignees
No one assigned
Labels
Next Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tringenbach @thomasnordquist @bj00rn