Allow for "+" wildcard in search expression #751
+21
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ression by
"+" in topic tree.
Watchout, the search expression changed to be case sensitive.
This has been carefully considered. The internal switch to regular expressions
and the use of that expression for the replacement in the topic tree has led
to two options
a) entering a search expression leads to a topic tree with all text lower cased
(independent of the casing in the search expression)
b) making the search expression case sensitive. Replacement does not change
casing of original topics.
Since MQTT-Topics are case sensitive themselves, option b) has been chosen.
|
@Kowalevskaja could you rebase this PR on master please, and give it some testing and ill try to get it merged. Thanks |
|
@bj00rn, happy to hear the project is alife. I rebased my pull request. Using the "+" wildcard in the search bar works as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Thomas
Many thanks for your great MQTT-Explorer! I added support for the "+" wildcard in search expressions.
Moreover, if the search expression contains a "+" wildcard the corresponding topic levels are grouped under a single node (re-)named to "+". For example, if there are messages available under the following topics:
and the search expression is "a/+/" the displayed tree becomes
Would love to see this feature merged into a future release. Parts of it might also contribute to issue #69.
Greets Georg
P.S. By the way, what are your plans for this project? Any chances you return? Any chances you release it under a more community friendly license?