-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Config and log management workflows #2844
Merged
didier-wenzek
merged 22 commits into
thin-edge:main
from
didier-wenzek:feat/config-and-log-management-workflows
May 31, 2024
Merged
feat: Config and log management workflows #2844
didier-wenzek
merged 22 commits into
thin-edge:main
from
didier-wenzek:feat/config-and-log-management-workflows
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didier-wenzek
temporarily deployed
to
Test Pull Request
April 26, 2024 16:10
— with
GitHub Actions
Inactive
Robot Results
|
This was referenced Apr 29, 2024
didier-wenzek
force-pushed
the
feat/config-and-log-management-workflows
branch
from
April 29, 2024 13:16
1b59fad
to
21e55cb
Compare
didier-wenzek
had a problem deploying
to
Test Pull Request
April 29, 2024 13:16
— with
GitHub Actions
Failure
reubenmiller
changed the title
Feat: Config and log management workflows
feat: Config and log management workflows
Apr 30, 2024
didier-wenzek
had a problem deploying
to
Test Pull Request
May 2, 2024 12:59
— with
GitHub Actions
Failure
11 tasks
didier-wenzek
had a problem deploying
to
Test Pull Request
May 2, 2024 14:04
— with
GitHub Actions
Failure
didier-wenzek
force-pushed
the
feat/config-and-log-management-workflows
branch
from
May 3, 2024 11:44
340cf1a
to
581d6d7
Compare
didier-wenzek
temporarily deployed
to
Test Pull Request
May 3, 2024 11:44
— with
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
didier-wenzek
force-pushed
the
feat/config-and-log-management-workflows
branch
from
May 7, 2024 12:43
581d6d7
to
672fd42
Compare
didier-wenzek
had a problem deploying
to
Test Pull Request
May 7, 2024 12:43
— with
GitHub Actions
Failure
didier-wenzek
temporarily deployed
to
Test Pull Request
May 14, 2024 13:09
— with
GitHub Actions
Inactive
didier-wenzek
temporarily deployed
to
Test Pull Request
May 14, 2024 13:21
— with
GitHub Actions
Inactive
didier-wenzek
force-pushed
the
feat/config-and-log-management-workflows
branch
from
May 14, 2024 14:19
fa4db4f
to
a988410
Compare
didier-wenzek
temporarily deployed
to
Test Pull Request
May 14, 2024 14:19
— with
GitHub Actions
Inactive
didier-wenzek
temporarily deployed
to
Test Pull Request
May 15, 2024 10:16
— with
GitHub Actions
Inactive
didier-wenzek
temporarily deployed
to
Test Pull Request
May 15, 2024 11:09
— with
GitHub Actions
Inactive
didier-wenzek
force-pushed
the
feat/config-and-log-management-workflows
branch
from
May 15, 2024 15:53
c1cb694
to
0bce80d
Compare
didier-wenzek
temporarily deployed
to
Test Pull Request
May 15, 2024 15:53
— with
GitHub Actions
Inactive
The builder is still expecting an MQTT connection, however the actor message box is now free of any MQTT aspects Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
TedgeOperationConverterActor can now process any type of builtin operations. Its builder still requires some knowledge of the available operations. However this will be fixed in following steps so the agent main can add any type of builtin operation such as log upload or config update. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Now the workflow actor (aka TedgeOperationConverterActor) has no more specific code related to the restart operation. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
To avoid name conflicts with TryFrom<Command> Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Now the workflow actor (aka TedgeOperationConverterActor) has no more specific code related to any specific operation. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
This is a preparation step to make the ConfigManagerActor MQTT independent and ready to be supported by agent workflows. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
…utput This is a preparation step to make the ConfigManagerActor MQTT independent and ready to be supported by agent workflows. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
A topic filter cannot be safely cast into a topic. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
The builder still expect an MQTT connection. This will be removed when connecting ConfigManagerActor to the workflow system. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
These operations can now be triggered as a sub-workflow. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Capability messages were erroneously sent twice for log upload, config snapshot and config update. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
The operation file cache has to be redesigned as it's currently not compatible with the workflow mechanism. - The operation file cache runs on the main device while the workflow system runs on a child device: hence the communication must be over MQTT or HTTP. - However, the operation-specific actors run behind the workflow actor and only the latter receives MQTT messages. A new mechanism is required for some messages to be pushed to the operation-specific actors. - Furthermore, the config update workflow currently use the same state (executing) for two different stages (before and after cache). This prevents the config update operation to be properly handled by workflow. I propose to disable - at least temporary, this cache for config updates. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
didier-wenzek
force-pushed
the
feat/config-and-log-management-workflows
branch
from
May 31, 2024 07:00
ca0f4cd
to
15b7e26
Compare
didier-wenzek
temporarily deployed
to
Test Pull Request
May 31, 2024 07:00
— with
GitHub Actions
Inactive
reubenmiller
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Great job (especially for the sustained effort!)
reubenmiller
added
theme:configuration
Theme: Configuration management
theme:troubleshooting
Theme: Troubleshooting and remote control
labels
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
theme:configuration
Theme: Configuration management
theme:troubleshooting
Theme: Troubleshooting and remote control
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update the log and config operations so those can be used by the workflow system,
enabling the ability to trigger a log or config update as a sub operation.
Types of changes
Paste Link to the issue
#2836
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments