fixing case where delegate_hash isn't available #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and this was raising an error. sidekiq + delayed_mailer and yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and this was raising an error. sidekiq + delayed_mailer and yaml
we use sidekiq's action_mailer extensions to add a delay
https://github.com/mperham/sidekiq/blob/v5.2.7/lib/sidekiq/extensions/action_mailer.rb#L33
which serializes yaml and then restores it when worker starts with
https://github.com/ruby/psych/blob/master/lib/psych/visitors/to_ruby.rb#L394
which hits your init_with and raises exception on some of the cleanup code.
so this pull fixes that by rescuing.
some inspection could also take place but the this seemed more risky.