Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument parsing for triangle/circumcircle to improve coverage #92

Open
wants to merge 1 commit into
base: feature/no-org
Choose a base branch
from

Conversation

dgtized
Copy link
Contributor

@dgtized dgtized commented Mar 9, 2022

Handles receiving a triangle, a map with points a,b,c and a sequential tuple of
three elements.

Also adds tests to cover these cases.

This allows constructions like (map t/circumcircle triangles) to work as expected instead of throwing errors around missing keys a,b,c.

However on the API design front, I'm a little hesitant about the use of instance?. I wonder if thi.ng.geom.core needs a ICircumcircle protocol, and not just the protocol with a bounding circle? It's also not clear how to handle this if the argument is a Triangle3 at this time?

Handles receiving a triangle, a map with points a,b,c and a sequential tuple of
three elements.

Also adds tests to cover these cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant