Merge pull request #67 from kinglozzer/62-error-message-code

FIX: error message/code may not always be set (fixes #62)
thephpleague · Dec 15, 2016 · 50bdec8 · 50bdec8
2 parents 035f147 + 3837060
commit 50bdec8
Show file tree

Hide file tree

Showing 4 changed files with 62 additions and 2 deletions.
diff --git a/src/Message/Response.php b/src/Message/Response.php
@@ -294,7 +294,7 @@ public function getInvoiceItemReference()
      */
     public function getMessage()
     {
-        if (!$this->isSuccessful()) {
+        if (!$this->isSuccessful() && isset($this->data['error']) && isset($this->data['error']['message'])) {
             return $this->data['error']['message'];
         }
 
@@ -310,7 +310,7 @@ public function getMessage()
      */
     public function getCode()
     {
-        if (!$this->isSuccessful()) {
+        if (!$this->isSuccessful() && isset($this->data['error']) && isset($this->data['error']['code'])) {
             return $this->data['error']['code'];
         }
 

diff --git a/tests/Message/ResponseTest.php b/tests/Message/ResponseTest.php
@@ -44,6 +44,32 @@ public function testPurchaseFailure()
         $this->assertNull($response->getSource());
     }
 
+    public function testPurchaseFailureWithoutMessage()
+    {
+        $httpResponse = $this->getMockHttpResponse('PurchaseFailureWithoutMessage.txt');
+        $response = new Response($this->getMockRequest(), $httpResponse->json());
+
+        $this->assertFalse($response->isSuccessful());
+        $this->assertFalse($response->isRedirect());
+        $this->assertSame('ch_1JEJGNWFYxAwgF', $response->getTransactionReference());
+        $this->assertNull($response->getCardReference());
+        $this->assertNull($response->getMessage());
+        $this->assertNull($response->getSource());
+    }
+
+    public function testPurchaseFailureWithoutCode()
+    {
+        $httpResponse = $this->getMockHttpResponse('PurchaseFailureWithoutCode.txt');
+        $response = new Response($this->getMockRequest(), $httpResponse->json());
+
+        $this->assertFalse($response->isSuccessful());
+        $this->assertFalse($response->isRedirect());
+        $this->assertSame('ch_1KGNWMAOUdAbbC', $response->getTransactionReference());
+        $this->assertNull($response->getCardReference());
+        $this->assertNull($response->getCode());
+        $this->assertNull($response->getSource());
+    }
+
     public function testCreateCustomerSuccess()
     {
         $httpResponse = $this->getMockHttpResponse('CreateCustomerSuccess.txt');

diff --git a/tests/Mock/PurchaseFailureWithoutCode.txt b/tests/Mock/PurchaseFailureWithoutCode.txt
@@ -0,0 +1,17 @@
+HTTP/1.1 402 Payment Required
+Server: nginx
+Date: Fri, 15 Feb 2013 18:26:37 GMT
+Content-Type: application/json;charset=utf-8
+Content-Length: 151
+Connection: keep-alive
+Cache-Control: no-cache, no-store
+Access-Control-Allow-Credentials: true
+Access-Control-Max-Age: 300
+
+{
+  "error": {
+    "message": "Your card was declined",
+    "type": "card_error",
+    "charge": "ch_1KGNWMAOUdAbbC"
+  }
+}
diff --git a/tests/Mock/PurchaseFailureWithoutMessage.txt b/tests/Mock/PurchaseFailureWithoutMessage.txt
@@ -0,0 +1,17 @@
+HTTP/1.1 402 Payment Required
+Server: nginx
+Date: Fri, 15 Feb 2013 18:26:37 GMT
+Content-Type: application/json;charset=utf-8
+Content-Length: 151
+Connection: keep-alive
+Cache-Control: no-cache, no-store
+Access-Control-Allow-Credentials: true
+Access-Control-Max-Age: 300
+
+{
+  "error": {
+    "type": "card_error",
+    "code": "card_declined",
+    "charge": "ch_1JEJGNWFYxAwgF"
+  }
+}