Support setting refreshToken #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #994 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 190 191 +1
===========================================
Files 20 20
Lines 514 516 +2
===========================================
+ Hits 514 516 +2
|
ramsey
reviewed
Apr 16, 2023
ramsey
approved these changes
Apr 16, 2023
|
Heya @ramsey @shadowhand could I bother you for a release with this PR? A few commits are missing from 2.7.0 2.7.0...master - thanks 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cases where the refresh token isn't included in the response when using it to refresh an access token, it's often necessary to persist the original refresh token for later use. When this happens it's convenient to store the refresh token in the
AccessTokenobject as it was originally.However, because
AccessToken::$refreshTokenis a protected property it's not possible to assign this value directly. ImplementingAccessToken::setRefreshToken()allows the refresh token to be set and stored along with theAccessTokenobject.The workaround I've found is to serialize the
AccessTokenobject to JSON, add the refresh token, then reinstantiate a newAccessTokenobject. It would be great if this wasn't necessary.Building the functionality directly into the library to automatically carry over the refresh token would be great (as suggested in #658), but I'm not sure if that behavior would apply to all cases. It might cause confusion if it was intentionally omitted from the response because it's no longer valid.
Related to #658