Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets default scope separator to space in line with the RFC, breaking most existing providers. You should not merge this pr. #922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrStonedOne
Copy link

@MrStonedOne MrStonedOne commented Oct 30, 2021

https://datatracker.ietf.org/doc/html/rfc6749#section-3.3

The authorization and token endpoints allow the client to specify the
scope of the access request using the "scope" request parameter. In
turn, the authorization server uses the "scope" response parameter to
inform the client of the scope of the access token issued.

The value of the scope parameter is expressed as a list of space-
delimited, case-sensitive strings.
The strings are defined by the
authorization server. If the value contains multiple space-delimited
strings, their order does not matter, and each string adds an
additional access range to the requested scope.

scope       = scope-token *( SP scope-token )
scope-token = 1*( %x21 / %x23-5B / %x5D-7E )

You should not merge this pr.

Somebody with more time than me who wanted to address this shortfalling, could code it such that the generic provider takes this as an argument/property that can be set on user code that uses the generic provider. Already a thing

Thank you and good day.

@ramsey
Copy link
Contributor

ramsey commented Dec 22, 2021

Thanks for the PR.

What's your goal with this? Is it for informational purposes? Do you want us to consider this for the next major version, since it has a breaking change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants