-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webmanifest to include screenshots #4806
base: master
Are you sure you want to change the base?
Conversation
See https://web.dev/patterns/web-apps/richer-install-ui for more information. In chrome devtools, you can see warnings by going to Application > Manifest tab. As for screenshots, I've found that on desktop they scale very poorly, so it needs to be zoomed in a lot. As well as private information such as IPs from your join message, and the user list should not include random users (for their sake). Perhaps a few messages should be sent to show link previews etc. Perhaps another screenshot with the server list open could be included for mobile. |
Considering that the screenshots are meant to showcase the app a bit, showing the server window is probably not quite the right thing to do. Link to https://thelounge.chat, hold a convo with some dummy users or whatever. Essentially the goal is to be as realistic as possible, showcasing the features, without putting anyone's privacy at risk that didn't give their consent. Feel free to use #thelounge-test, that's just "wendy" and I (bookworm), both are non secret so feel free to bug wendy with commands / expose our IPs etc. both are joined from hosts I control. |
@brunnre8 I'm not sure I understand, I tried to join thelounge-test channel and chat, but I am not getting any responses. Is it good enough if I just add the following?
|
Do you understand why the linter yells at us? I don't understand why you'd want to show a login screen? It's not interesting. You want to have pictures which are appealing, showcasing what the app can do. https://thelounge.chat/img/thelounge-screenshot.png ^ this is an example from our webpage, see it showcases some fun things you can't do in other clients... audio, link preview etc. THAT is what this issue is about, not just putting some random images into our repo to shut the linter up. |
I was not able to reproduce the issue mentioned locally but these changes should fix the problems mentioned. Please let me know if you approve of these changes.