Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and linting #46

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Dec 18, 2019

Howdy!

Was just going through my packages using deprecated packages, and noticed kld-intersections had a couple. Also updates per latest linting.

  • Linting (ESLint): As per latest ash-nazg (prefer for...of, accurate and complete jsdoc where present; prefer specific jsdoc array type)
  • Linting (ESLint): Lint any JS in HTML
  • npm: Update gp-data-transformer dep and devDeps
  • npm: Move from deprecated opn-cli and rollup-plugin-node-resolve packages to replacements
  • npm: Fix node engines
  • Maintenance: Add .editorconfig to assist IDEs in tabbing behavior

You might also want to take a look at the ShapeInfo info. The class has args but does not use it and its create helper accepts object but it is always an array.

Hope all is well!

… and complete jsdoc where present; prefer specific jsdoc array type)

- Linting (ESLint): Lint any JS in HTML
- npm: Update gp-data-transformer dep and devDeps
- npm: Move from deprecated `opn-cli` and `rollup-plugin-node-resolve` packages to replacements
- npm: Fix node `engines`
- Maintenance: Add `.editorconfig` to assist IDEs in tabbing behavior

Note that ShapeInfo has `args` but does not use it and its `create` helper accepts `object` but it is always an array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant