Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE section issues #212

Open
le-ander opened this issue Jun 13, 2023 · 1 comment
Open

DE section issues #212

le-ander opened this issue Jun 13, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@le-ander
Copy link
Member

I'm just looking at the DE section of the best practice book and noticed two potential issues with the aggregate_and_filter() function:

The text says "For each patient we create 1 pseudobulk sample per cell type by aggregating the cell from each subpopulation and taking the mean gene expression within that subpopulation." but in the function, counts are summed rather than mean aggregated. Additionally, it might be helpful to add any required columns (eg. "donor_key", "condition_key" etc) to the 'obs_to_keep' list to prevent an error where the donor_key is not found in the donor_df

@le-ander le-ander added the bug Something isn't working label Jun 13, 2023
@alitinet
Copy link
Contributor

Hi, should be fixed after we move to decoupler (#141).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants