Consider account status during auth and refactor API around blueprints #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1767 ↗︎
Details:
Review all test suite changes for PR #727 ↗︎ |
|||||||||||||||
ml-evs
force-pushed
the
ml-evs/account-status-auth
branch
from
de0dfd1
to
19a96fa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
==========================================
+ Coverage 66.89% 67.25% +0.36%
==========================================
Files 62 62
Lines 3727 3747 +20
==========================================
+ Hits 2493 2520 +27
+ Misses 1234 1227 -7
|
ml-evs
force-pushed
the
ml-evs/account-status-auth
branch
from
394bed2
to
3af8105
Compare
ml-evs
changed the title
ml-evs
force-pushed
the
ml-evs/account-status-auth
branch
from
3af8105
to
2b5338d
Compare
ml-evs
requested review from
jdbocarsly and
BenjaminCharmes
and removed request for
jdbocarsly
ml-evs
force-pushed
the
ml-evs/account-status-auth
branch
from
2b5338d
to
418e93a
Compare
BenjaminCharmes
approved these changes
May 15, 2024
Fix trailing slash on new route Add convenience property for account status on `LoginUser`
…cess the items endpoints
ml-evs
force-pushed
the
ml-evs/account-status-auth
branch
from
418e93a
to
bd2ecc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #710 by refactoring all routes around blueprints and introducing some new decorators for permissions based on
account_status.