Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Block reworks #616

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[WIP]: Block reworks #616

wants to merge 6 commits into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Feb 25, 2024

This PR begins the gradual process of overhauling the data blocks. I've started doing this in steps, that could themselves form separate PRs.

  • Retain current block format as a legacy submodule, and switch all existing blocks to that format
  • Add draft of a new base block with (somewhat) extensible block schemas and lifecycle hooks
  • Update existing routes to work with both legacy and new style blocks
  • Try migrating a few blocks to see how they "feel" (started with chat block arbitrarily)

Probably the first point should be merged independently so we can freely try out several possible designs for 2/3.

Copy link

cypress bot commented Feb 25, 2024

3 failed tests on run #1039 ↗︎

3 23 0 0 Flakiness 0

Details:

Merge 29c7b93 into c0a6458...
Project: datalab Commit: 51d8767946 ℹ️
Status: Failed Duration: 01:40 💡
Started: Feb 25, 2024 1:11 PM Ended: Feb 25, 2024 1:13 PM
Failed  editPage.cy.js • 1 failed test

View Output

Test Artifacts
Edit Page > Add some blocks to the sample and checks unsaved warning behavior Test Replay Screenshots
Failed  sampleTablePage.cy.js • 2 failed tests

View Output

Test Artifacts
Advanced sample creation features > checks the edit page of the copied sample Screenshots
Advanced sample creation features > checks the edit page of the copied sample with components Screenshots

Review all test suite changes for PR #616 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant