[DRAFT] update install instructions #560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #791 ↗︎
Details:
Review all test suite changes for PR #560 ↗︎ |
|||||||||||||||
ml-evs
reviewed
Feb 13, 2024
| @@ -43,7 +43,7 @@ The server should now be accessible at [http://localhost:5001](http://localhost: | |||
|
|
|||
| Should you wish to contribute to/modify the Python code, you may wish to perform these extra steps: | |||
|
|
|||
| 1. From within the `pydatalab` folder, run `pipenv install --dev` to pull the development dependencies (e.g., `pre-commit`, `pytest`). | |||
| 1. From within the `pydatalab` folder, run `pipenv install --dev` to pull the development dependencies (e.g., `pre-commit`, `pytest`). You may also need to install `pre-commit` globally. | |||
There was a problem hiding this comment.
I don't think this is the case, but probably you need to run pipenv run pre-commit install the first time, which we don't say below...
There was a problem hiding this comment.
I jotted this down as a draft while we were struggling getting it to run on a clean install. I think the problem was that pre-commit didn't work when git commit was run outside of the pipenv. The solution may be to run everything from inside the pipenv.
There was a problem hiding this comment.
If you install it the first time inside pipenv I think it should work; pre-commit install is simply copying a bash script into .git/hooks/pre-commit and it "remembers" the Python executable that it was first installed by.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some issues with the current install instructions