Added preliminary Raman mapping block #534
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Hi @elbee99, great work on this so far! Just a couple of comments -- if you are happy with the state of how this is now working, I'm happy to refactor it into the old block myself, then the selection of spectra etc. can be left as a future PR?
| @@ -1,6 +1,6 @@ | |||
| #Acq. time (s)= 300 | |||
| #Accumulations= 12 | |||
| #Range (cm-�)= 200...800 | |||
| #Range (cm-�)= 200...800 | |||
There was a problem hiding this comment.
Any idea what's going on here @elbee99? Assume vscode or something just mangled this file (presumably we should revert these changes)
| @@ -0,0 +1,3 @@ | |||
| from .blocks import RamanMapBlock | |||
There was a problem hiding this comment.
Do you think there is any need to separate this out as a new block? I think ideally this should be factored into the other one, and then perhaps in cases where the data is 3D and you actually want a 1D plot we can add that as an option.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
==========================================
- Coverage 66.25% 65.01% -1.25%
==========================================
Files 60 62 +2
Lines 3586 3693 +107
==========================================
+ Hits 2376 2401 +25
- Misses 1210 1292 +82
|
Have created a block for reading Renishaw *.wdf files for Raman mapping experiments. In its current state, the image doesn't appear on the plot where it should, and am not sure why.