Add alliance details to team detail page #5937
Open
+515
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## py3 #5937 +/- ##
==========================================
- Coverage 93.10% 92.88% -0.22%
==========================================
Files 658 659 +1
Lines 42145 42670 +525
Branches 60 60
==========================================
+ Hits 39241 39636 +395
- Misses 2896 3026 +130
Partials 8 8 ☔ View full report in Codecov by Sentry. |
fangeugene
reviewed
May 25, 2024
fangeugene
reviewed
May 25, 2024
ScreenshotsHomepage
GameDay
|
fangeugene
reviewed
Jun 5, 2024
| @@ -188,7 +235,7 @@ <h4>District Points Earned</h4> | |||
| <p class="muted">No matches played.</p> | |||
| {% else %} | |||
| <p class="muted">No matches yet. Check back after {{ comp.event.start_date|strftime("%B %d, %Y") }}.</p> | |||
| {% endif %} | |||
| {% endif %} | |||
| event.event_type_enum, event.year | ||
| ) | ||
|
|
||
| alliance, alliance_pick = AllianceHelper.get_alliance_details_and_pick_name( |
There was a problem hiding this comment.
get_known_alliance_size is called within this helper. Would it make sense to remove the redundant call above and have get_alliance_details_and_pick_name also return alliance_size?
|
|
||
| alliance_size = cls.get_known_alliance_size(event.event_type_enum, event.year) | ||
|
|
||
| for alliance_check in none_throws(event.alliance_selections): |
There was a problem hiding this comment.
if either of the if statements below match, we should be able to break out of the for loop right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides details about Alliance Selection and that Alliance's progression.
Motivation and Context
I often find myself switching back and forth between event pages and alliance pages to determine an team's alliance, and find that the data should just be presented inline.
How Has This Been Tested?
There seem to be no automated tests for the team renderer, so no automated tests were done. Manual tests were done with:
Screenshots (if appropriate):
Types of changes