This repository has been archived by the owner on Jun 9, 2021. It is now read-only.
Moved doc properties to logical classes #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like where you're going. But can't we be a bit more bold and move most of this directly to the operations? |
dodijk
force-pushed
the
feature/38/doc-mixins
branch
from
cb505c4
to
2ad3e6c
Compare
dodijk
commented
Aug 10, 2018
dodijk
force-pushed
the
feature/38/doc-mixins
branch
from
2ad3e6c
to
6c12b0d
Compare
dodijk
changed the title
dodijk
force-pushed
the
feature/38/doc-mixins
branch
3 times, most recently
from
922cd8c
to
66c8404
Compare
dodijk
force-pushed
the
feature/38/doc-mixins
branch
from
66c8404
to
08b0d0e
Compare
|
Why wouldn't you directly subclass a SpaCy Doc, and then organise the additions into mixins? That way you'd get a whole bunch of utility functions from the SpaCy docs for free (serializationn for example), and it would let you "compose" your Doc in the pipeline. Added benefit of that is that you could skip some of the stuff you don't need (especially when that loads a bunch of data in memory), which would be faster and cheaper to run. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for discussion as first steps for resolving #38 and #39. I started with grouping properties into subclasses of Doc. These can be than moved to separate files and be integrated with the respective operators (not entirely sure on how we will do this yet). Feedback welcome.