Update lastValue whenever ngModel property update programmatically #1042
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scenario:
- We have two textbox bind with ngModel properties respectively and (ngModelChange) event bind to these.
- On change in first textbox value need to update second textbox ngModel property which is reflecting.
(when you have update ngModel property programmatically then it trigger write function but not update the last value hence then you change the ngModel value and its not
triggered this._onChange();).
- But After programmatically update value, when remove the value from second textbox (ngModelChange) will not trigger because this.lastValue has not been updated in previous writeValue function.
|
Please review this single line PR as its must needed for our product. We are using this package v8.0.2 and version update will cost whole application update and test cycles. Hence this PR merge give us major relief and solve our bug scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario:
We have two textbox bind with
ngModelproperties respectively and(ngModelChange)event bind to these.On change in first textbox value need to update second textbox
ngModelproperty which is reflecting.(when you have update
ngModelproperty programmatically then it triggerwriteValuefunction but not update thelastValuehence then you change thengModelvalue and its not triggeredthis._onChange();).But After programmatically update value, when remove the value from second textbox
(ngModelChange)will not trigger becausethis.lastValuehas not been updated in previouswriteValuefunction.Issue Produced StackBlitz Please have a look and follow the steps to produce it.