New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proxy wait for response #248

Open

pedrosimeao-7egend wants to merge 1 commit into testinggospels:develop from pedrosimeao-7egend:fix/proxy-wait-for-response

pedrosimeao-7egend commented Feb 20, 2024 •

edited

Description

This PR includes 3 fixes:

Proxy was not waiting for response, so it didn't work
Proxy configuration requires optional ssl option
On parser error, the response status code was 200 (replaced to 500)

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

{
    "target": "https://random-data-api.com/api/users/random_user",
    "followRedirects": false,
    "changeOrigin": true,
    "ignorePath": true
}

OS: MacOS
Node version: 20.11.0
NPM Version: 10.2.4

Checklist:

My code follows the guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
This does not break any existing functionalities
Any dependent changes have been merged and published in downstream modules


          Fix proxy wait for response

811cbea

Author

pedrosimeao-7egend commented Apr 5, 2024

@shubhendumadhukar any chance to get this into a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment