Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no view found for id when using API 24. #165

Open
wants to merge 2 commits into
base: fondazione
Choose a base branch
from
Open

Fix no view found for id when using API 24. #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ddfd9f
Fix no view found for id when using API 24.
Oct 5, 2021
08af077
Merge pull request #1 from OKatrych/bug/api24-missing-id
OKatrych Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions fondazione/src/main/java/com/github/terrakok/fondazione/AppActivity.kt
View file
Open in desktop
Expand Up @@ -3,12 +3,12 @@ package com.github.terrakok.fondazione
import android.os.Bundle
import android.widget.FrameLayout
import androidx.appcompat.app.AppCompatActivity
import androidx.core.view.ViewCompat
import com.github.terrakok.cicerone.Cicerone
import com.github.terrakok.cicerone.Navigator
import com.github.terrakok.cicerone.Router
import com.github.terrakok.cicerone.Screen
import com.github.terrakok.cicerone.androidx.AppNavigator
import kotlin.random.Random

open class AppActivity : AppCompatActivity() {
private lateinit var ciceroneKey: String
Expand All @@ -24,7 +24,7 @@ open class AppActivity : AppCompatActivity() {
private val navigator by lazy { createNavigator() }
protected open fun createNavigator(): Navigator = AppNavigator(this, navigationContainerId)

protected open val navigationContainerId: Int = Random.nextInt()
protected open val navigationContainerId: Int = ViewCompat.generateViewId()
protected open val rootScreen: Screen? = null

override fun onCreate(savedInstanceState: Bundle?) {
Expand Down
4 changes: 2 additions & 2 deletions fondazione/src/main/java/com/github/terrakok/fondazione/NavigationFragment.kt
View file
Open in desktop
Expand Up @@ -5,12 +5,12 @@ import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import android.widget.FrameLayout
import androidx.core.view.ViewCompat
import com.github.terrakok.cicerone.Cicerone
import com.github.terrakok.cicerone.Navigator
import com.github.terrakok.cicerone.Router
import com.github.terrakok.cicerone.Screen
import com.github.terrakok.cicerone.androidx.AppNavigator
import kotlin.random.Random

open class NavigationFragment : AppFragment() {
private lateinit var ciceroneKey: String
Expand All @@ -31,7 +31,7 @@ open class NavigationFragment : AppFragment() {
}
}

protected open val navigationContainerId: Int = Random.nextInt()
protected open val navigationContainerId: Int = ViewCompat.generateViewId()
protected open val rootScreen: Screen? = null

override fun onCreate(savedInstanceState: Bundle?) {
Expand Down