Added 'attributes.py', 'colors.py', and 'highlights.py' for better constants management #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstants management Added constant files for standardizing the use of attributes, colors, and highlights To enhance code readability and maintainability, three constant files have been created: 'attributes.py', 'colors.py', and 'highlights.py'. These files contain constants for text attributes (such as 'bold', 'underline'), text colors, and background colors, respectively. This structure allows for easy referencing and uniform use of these values across the project, facilitating future modifications and the organized inclusion of new values.
for more information, see https://pre-commit.ci
|
Thanks for the suggestion, but I'm not too clear on the benefit here, and it's introducing (unused) duplication. I think the current situation is fine, the
Please could you expand on this? What sort of inconsistencies and challenges? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces three new constant files: attributes.py, colors.py, and highlights.py, aimed at standardizing the usage of text attributes, text colors, and background highlights across the project. Previously, such values were hardcoded throughout the codebase, leading to inconsistencies and a challenging environment for future modifications.