Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-op #6787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

no-op #6787

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions tfx/orchestration/experimental/core/env.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ def get_orchestration_options(
def get_base_dir(self) -> Optional[str]:
"""Returns the base directory for the pipeline."""

@abc.abstractmethod
def label_and_tag_pipeline_run(
self, mlmd_handle, pipeline_id, pipeline_run_id, labels, tags
) -> None:
"""Labels and tags the pipeline run after it starts."""

@abc.abstractmethod
def max_mlmd_str_value_length(self) -> Optional[int]:
"""Returns max size of a string value in MLMD db, `None` if unlimited."""
Expand Down Expand Up @@ -111,6 +117,11 @@ def get_orchestration_options(
def get_base_dir(self) -> Optional[str]:
return None

def label_and_tag_pipeline_run(
self, mlmd_handle, pipeline_id, pipeline_run_id, labels, tags
) -> None:
return None

def max_mlmd_str_value_length(self) -> Optional[int]:
return None

Expand Down
5 changes: 5 additions & 0 deletions tfx/orchestration/experimental/core/env_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ def get_orchestration_options(self, pipeline):
def get_base_dir(self):
raise NotImplementedError()

def label_and_tag_pipeline_run(
self, mlmd_handle, pipeline_id, pipeline_run_id, labels, tags
):
raise NotImplementedError()

def max_mlmd_str_value_length(self):
raise NotImplementedError()

Expand Down