Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address tfjs-layers typos in documentation strings #8190

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gaikwadrahul8
Copy link
Contributor

Hi, Team
I've identified and corrected several typos within the documentation strings (code comments) of .ts files in the tfjs-layers folder. I believe these corrections will improve the clarity and accuracy of the documentation for users. I appreciate your time and look forward to your feedback. Thank you.

Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattsoulanille
Copy link
Member

It looks like the linter is failing due to line length limits.

/workspace/tfjs-layers/src/engine/container.ts:673:1
ERROR: 673:1  max-line-length  Exceeds maximum line length of 80

/workspace/tfjs-layers/src/engine/training_test.ts:503:1
ERROR: 503:1  max-line-length  Exceeds maximum line length of 80

https://pantheon.corp.google.com/cloud-build/builds/ce0f1f4c-bbe7-42eb-966e-43147de417d1;step=4?project=learnjs-174218

@gbaned
Copy link

gbaned commented Mar 18, 2024

Hi @gaikwadrahul8 Can you please check the above comment from @mattsoulanille. Thank you!

@gaikwadrahul8
Copy link
Contributor Author

Hi, @gbaned

I apologize for the delayed response and now I have added new commit to take care of linter failing issue due to line length limits. Thank you.

@pyu10055 pyu10055 enabled auto-merge (squash) April 12, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants