Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedding Projector: fix camera controls #6286

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Embedding Projector: fix camera controls #6286

wants to merge 2 commits into from

Conversation

alicialics
Copy link
Contributor

@alicialics alicialics commented Apr 4, 2023 •
edited

Motivation for features / changes

OrbitControl in Embedding Projector is not working.
The current code is noop (because of a different Three.js version?)
That means that:

  1. 2D mouse controls are not working as expected (cannot pan camera)
  2. 3D mouse controls are just using Three.js defaults

Technical description of changes

Remove all 3D orbitControl code handling since they are noop
Fixes 2D camera panning

Screenshots of UI changes

N/A

Detailed steps to verify changes work correctly (as executed by you)

  1. Toggle t-SNE 2D mode
  2. Verify left mouse pans

Alternate designs / implementations considered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin:projector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alicialics @nfelt