Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalars_and_keras.ipynb #4902

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rmothukuru
Copy link

Added a statement to visualize Metrics, in Tensorboard Scalars Documentation

  • Motivation for features / changes : Point raised in this issue

  • Technical description of changes : Explanation to Visualizing Metrics was missing in the documentation.

  • Screenshots of UI changes

  • Detailed steps to verify changes work correctly (as executed by you) : Verified it in my Branch

  • Alternate designs / implementations considered : This is just a Documentation change

Added a statement to visualize `Metrics`, in Tensorboard Scalars Documentation
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@wchargin wchargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a loud disclaimer, could we just add metrics=['accuracy']
to our sample model above? It seems likely that users will already be
tracking metrics that they’re interested in, so no need to draw their
attention to an Important Note; we can just demonstrate the right
workflow.

@rmothukuru
Copy link
Author

rmothukuru commented Apr 27, 2021

Instead of a loud disclaimer, could we just add metrics=['accuracy']
to our sample model above? It seems likely that users will already be
tracking metrics that they’re interested in, so no need to draw their
attention to an Important Note; we can just demonstrate the right
workflow.

@wchargin,
We can do that but then the Tensorboard Graph, which shows only Loss, has to be updated, and even the Heading, training_the_model_and_logging_loss needs to be changed.

Please let me know how to proceed. Thanks!

@bmd3k bmd3k removed their request for review April 30, 2021 14:06
@psybuzz
Copy link
Contributor

psybuzz commented May 10, 2021

To chime in, I think it is reasonable to add metrics=['accuracy'] and update the docs accordingly, with updated headings, instructions, and screenshots as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only Visualization of Loss is demonstrated in Tensorboard Scalars Documentation
3 participants