Support more hkv strategy #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinGeLin
force-pushed
the
support_more_hkv_strategy
branch
3 times, most recently
from
7a2e790
to
99003de
Compare
jq
reviewed
Mar 22, 2024
tensorflow_recommenders_addons/dynamic_embedding/python/ops/hkv_hashtable_ops.py
Outdated
Show resolved
Hide resolved
tensorflow_recommenders_addons/dynamic_embedding/python/ops/hkv_hashtable_ops.py
Show resolved
Hide resolved
tools/docker/cuda11.2.2-cudnn8-ubuntu20.04-manylinux2014-multipython.Dockerfile
Outdated
Show resolved
Hide resolved
LinGeLin
force-pushed
the
support_more_hkv_strategy
branch
from
99003de
to
a039746
Compare
|
Hi @LinGeLin, it would be better to add a |
rhdong
reviewed
Mar 24, 2024
tools/docker/cuda11.2.2-cudnn8-ubuntu20.04-manylinux2014-multipython.Dockerfile
Outdated
Show resolved
Hide resolved
rhdong
reviewed
Mar 24, 2024
...orflow_recommenders_addons/dynamic_embedding/python/kernel_tests/hkv_hashtable_evict_test.py
Outdated
Show resolved
Hide resolved
rhdong
reviewed
Mar 24, 2024
...orflow_recommenders_addons/dynamic_embedding/python/kernel_tests/hkv_hashtable_evict_test.py
Outdated
Show resolved
Hide resolved
rhdong
reviewed
Mar 24, 2024
...orflow_recommenders_addons/dynamic_embedding/python/kernel_tests/hkv_hashtable_evict_test.py
Outdated
Show resolved
Hide resolved
LinGeLin
force-pushed
the
support_more_hkv_strategy
branch
2 times, most recently
from
6229244
to
066d50b
Compare
LinGeLin
force-pushed
the
support_more_hkv_strategy
branch
from
eaf7911
to
04e0e9b
Compare
|
Good job! Thank you @LinGeLin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support more hkv evict strategy
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*