Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]Rocksdb backend #121

Open
wants to merge 67 commits into
base: master
Choose a base branch
from
Open

Conversation

bashimao
Copy link
Contributor

RocksDB backend for TFRA Hastabale.

@bashimao bashimao requested a review from rhdong as a code owner July 20, 2021 16:44
@rhdong
Copy link
Member

rhdong commented Jul 21, 2021

Hi @bashimao , thank you for your contribution , and can you squash your commits to one and describe your feature detail in your comment?

@rhdong rhdong requested a review from a user July 21, 2021 07:53
@tensorflow tensorflow deleted a comment from google-cla bot Mar 27, 2022
@tensorflow tensorflow deleted a comment from google-cla bot Mar 27, 2022
@tensorflow tensorflow deleted a comment from google-cla bot Mar 27, 2022
@tensorflow tensorflow deleted a comment from google-cla bot Mar 27, 2022
@tensorflow tensorflow deleted a comment from google-cla bot Mar 27, 2022
@tensorflow tensorflow deleted a comment from google-cla bot Mar 27, 2022
@tensorflow tensorflow deleted a comment from google-cla bot Mar 27, 2022
@tensorflow tensorflow deleted a comment from google-cla bot Mar 27, 2022
@tensorflow tensorflow deleted a comment from google-cla bot Mar 27, 2022
@tensorflow tensorflow deleted a comment from google-cla bot Mar 27, 2022
@tensorflow tensorflow deleted a comment from google-cla bot Mar 27, 2022
@tensorflow tensorflow deleted a comment from google-cla bot Mar 27, 2022
@bashimao
Copy link
Contributor Author

@rhdong What could case this? @MoFHeka

root@13beb51e47e9:/# python
Python 3.7.7 (default, Jan 19 2022, 04:18:49) 
[GCC 7.5.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from tensorflow_recommenders_addons import dynamic_embedding as de
2022-03-27 20:28:04.992289: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library libcudart.so.11.0
WARNING:tensorflow:dynamic_embedding.GraphKeys has already been deprecated. The Variable will not be added to collections because it does not actully own any value, but only a holder of tables, which may lead to import_meta_graph failed since non-valued object has been added to collection. If you need to use `tf.compat.v1.train.Saver` and access all Variables from collection, you could manually add it to the collection by tf.compat.v1.add_to_collections(names, var) instead.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.7/site-packages/tensorflow_recommenders_addons/__init__.py", line 29, in <module>
    from tensorflow_recommenders_addons import dynamic_embedding
  File "/usr/local/lib/python3.7/site-packages/tensorflow_recommenders_addons/dynamic_embedding/__init__.py", line 58, in <module>
    from tensorflow_recommenders_addons.dynamic_embedding.python.ops.cuckoo_hashtable_ops import (
  File "/usr/local/lib/python3.7/site-packages/tensorflow_recommenders_addons/dynamic_embedding/python/ops/cuckoo_hashtable_ops.py", line 33, in <module>
    cuckoo_ops = LazySO("dynamic_embedding/core/_cuckoo_hashtable_ops.so").ops
  File "/usr/local/lib/python3.7/site-packages/tensorflow_recommenders_addons/utils/resource_loader.py", line 102, in ops
    self._ops = tf.load_op_library(get_path_to_datafile(self.relative_path))
  File "/usr/local/lib/python3.7/site-packages/tensorflow/python/framework/load_library.py", line 58, in load_op_library
    lib_handle = py_tf.TF_LoadLibrary(library_filename)
tensorflow.python.framework.errors_impl.NotFoundError: /usr/local/lib/python3.7/site-packages/tensorflow_recommenders_addons/dynamic_embedding/core/_cuckoo_hashtable_ops.so: undefined symbol: _ZN10tensorflow14kernel_factory17OpKernelRegistrar12InitInternalEPKNS_9KernelDefEN4absl12lts_2021032411string_viewESt10unique_ptrINS0_15OpKernelFactoryESt14default_deleteIS9_EE

@@ -12,13 +12,22 @@ filegroup(
visibility = ["//visibility:public"],
)

make(
# Enable this to compile RocksDB from source instead.
#make(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants